Skip to content

fix(remappings): explicit lib remappings should override detected #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix(remappings): explicit lib remappings should override detected #9263

wants to merge 5 commits into from

Conversation

@grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Nov 5, 2024

Motivation

Closes #4717
Closes #6431

Solution

zerosnacks added a commit to zerosnacks/foundry-bug-6431-repro that referenced this pull request Nov 5, 2024
@zerosnacks
apply proposed fix of foundry-rs/foundry#9263 - works!
c79750b
@grandizzy grandizzy mentioned this pull request Nov 5, 2024
Closed
2 tasks
@grandizzy grandizzy added the T-likely-breaking Type: requires changes that can be breaking label Nov 6, 2024
@yaroslavyaroslav
Copy link

yaroslavyaroslav commented Dec 20, 2024

Just for sake of history, if some one stuck in the work because of No such file or directory (os error 2) same as I did. This very PR solves the problem. Feel free to fetch and build it locally.

@grandizzy grandizzy self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky will be requested when the pull request is marked ready for review 0xrusowsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@grandizzy grandizzy

Labels

T-likely-breaking Type: requires changes that can be breaking

Projects

Foundry
Archived in project

Milestone

No milestone

2 participants

@grandizzy @yaroslavyaroslav