Skip to content

Adjust trace resources tests #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddoktorski wants to merge 139 commits into from
Closed

Adjust trace resources tests #2985

ddoktorski wants to merge 139 commits into from

Conversation

@ddoktorski
Copy link
Collaborator

@ddoktorski ddoktorski commented Feb 22, 2025

Closes #2955

Introduced changes

  • Removed tests for syscalls, given that they are no longer present in the call trace format. Therefore, we shouldn't test them here. Similar integration tests could potentially be added in the future, but:
    • Asserting syscalls for nested calls would be problematic
    • We already have tests to check resources in the resources.rs file

Note: Currently tests for builtins fail, which seems unexpected. For example a call to TraceInfoProxy constructor uses 9 pedersen_builtin now instead of 2. The current value does not seem accurate. It is worth double checking whether we count used resources correctly.

kkawula and others added 30 commits January 21, 2025 20:48
@kkawula
Update Cargo.toml
8840619
@kkawula
Fix 0
28c45de
@kkawula
Fix imports
3a300f1
@kkawula
Undo unnecessary lock update
4f00198
@kkawula
Use blockifier and starknet_api from crates.io
66f4b8e
@kkawula
Fix 4
afdc132
@kkawula
Rename get_compiled_contract_class to get_compiled_class
e37424a
@kkawula
Fix imports
9cdc581
@kkawula
Update verify_syscall_ptr return type
69117b5
@kkawula
Specify int size for From triat
a8a58a8
@kkawula
Moc From impl for GasPrices and SerializableGasPrices
320be6b
@kkawula
Fix imports
ec98539
@kkawula
Update get_compiled_class return type
a60a110
@kkawula
Revert changes in 'StarknetRuntime' struct
57af9ee
@kkawula
Add Mock comment
16eab87
@kkawula
Revert verify_syscall_ptr type change
3d469df
@kkawula
Add Mock comment
23e7b5d
@kkawula
Some fixes
ab1a722
@kkawula
Add mock comment
c239c2c
@kkawula
Some fixes
9bd480f
@kkawula
Some fixes - update imports
51bb4b6
@kkawula
Fix error match
dda8c59
@kkawula
Fix
c32f3bf
@cptartur
Compiles
96e7854
@cptartur
Make
7ad3ed5
@cptartur
Fix panic data extraction logic for string, disable for shortstrings …
f7d8b8f 
…(All blockifier tests pass)
@cptartur
Disable asserted gas values in non-gas tests
00f48b2
@cptartur
Move builtins test to separate file
7371458
@cptartur
Disable fuzzing tests
eb4249f
@cptartur
Try handling segment index offsets
ac9d4f8
cptartur and others added 18 commits February 20, 2025 14:29
@cptartur
Link issue in code
8cb4339
@cptartur
Disable default features
7d6d00d
@cptartur
Merge branch 'kkawula/2862-blockifier-windows-compatible-fork' into k…
2d6975b 
…kawula/2862-bump-cairo-and-blockifier
@cptartur
Relock
67ad52a
@cptartur
Lint
8472cf3
@cptartur
Bump starknet, assert_macros, remove unused code
a5cf9be
@cptartur
Remove scarb 2.7.0 override in cast tests
25e8a25
@cptartur
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' into 2964-docs-…
e55274a 
…tests
@cptartur
Remove unused argument
2e39f55
@cptartur
Do not hardcode use_kzg_da
db377e3
@cptartur
Link to sierra gas issue
1c39a6f
@cptartur
Change fixme to todo
9b69e26
@cptartur
Copy updated code, link to source
6ff179f
@cptartur
Merge branch '2964-docs-tests' into kkawula/2862-bump-cairo-and-block…
4d87d44 
…ifier
@cptartur
Remove commented out code
f1a8461
@franciszekjob
Merge branch 'master' of https://github.com/foundry-rs/starknet-foundry…
452cc35 
… into kkawula/2862-bump-cairo-and-blockifier
@franciszekjob
Merge branch 'kkawula/2862-bump-cairo-and-blockifier' of https://gith…
03f554a 
…ub.com/foundry-rs/starknet-foundry into kkawula/2862-bump-cairo-and-blockifier
@ddoktorski
Adjust trace resources tests
b8a0e0e
Base automatically changed from kkawula/2862-bump-cairo-and-blockifier to master February 25, 2025 11:29
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

Hi! This pull request hasn't had any activity for a while, so I am
marking it as stale. It will close in 14
days if it is not updated. Thanks for contributing!

@github-actions github-actions bot added the stale Stale Bot label Mar 28, 2025
@cptartur cptartur removed the stale Stale Bot label Mar 28, 2025
@github-actions
Copy link

github-actions bot commented Apr 28, 2025

Hi! This pull request hasn't had any activity for a while, so I am
marking it as stale. It will close in 14
days if it is not updated. Thanks for contributing!

@github-actions github-actions bot added the stale Stale Bot label Apr 28, 2025
@cptartur cptartur removed the stale Stale Bot label May 7, 2025
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Hi! This pull request hasn't had any activity for a while, so I am
marking it as stale. It will close in 14
days if it is not updated. Thanks for contributing!

@github-actions github-actions bot added the stale Stale Bot label Jun 9, 2025
@github-actions
Copy link

github-actions bot commented Jun 23, 2025

This pull request has been automatically closed due to inactivity.
Feel free to reopen it or create a new one if needed.
Thanks for contributing!

@github-actions github-actions bot closed this Jun 23, 2025
@ddoktorski ddoktorski deleted the restore-trace-resources-test branch July 2, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale Stale Bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore tests from trace_resources.rs file

7 participants

@ddoktorski @cptartur @kkawula @franciszekjob @THenry14 @ksew1