Merged
Conversation
Types.py line 277: bug in ptr_size where width needed to be in bits, not bytes. Change GoTypePointer class so that it no longer dereferences the addr parameter, which best I can tell is never given indirectly in an eface. Pointer dereferencing behaviour was depended upon by GoDataInterface, which was amended to do its own dereference where required. Also added a new type representation for a nil interface, which is where you have a line of code in Go such as: var myVar any = nil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types.py: bug in ptr_size where width needed to be in bits, not bytes.
Change GoTypePointer class so that it no longer dereferences the addr parameter, which best I can tell is never given indirectly in an eface.
Pointer dereferencing behaviour was depended upon by GoDataInterface, which was amended to do its own dereference where required.
Also added a new type representation for a nil interface, which is where you have a line of code in Go such as:
var myVar any = nil