Skip to content

Improve more NTDS attributes#55

Open
Schamper wants to merge 1 commit intomainfrom
ntds-more-attrs
Open

Improve more NTDS attributes#55
Schamper wants to merge 1 commit intomainfrom
ntds-more-attrs

Conversation

@Schamper
Copy link
Copy Markdown
Member

  • Add more typed attributes
  • Move some attribute decoding from "global" decoding to class specific
    • The benefit of this is so that we don't fill up ATTRIBUTE_ENCODE_DECODE_MAP with every attribute that requires some additional type tweaking, but keep that logic separated with the classes. The reason for doing additional decoding this way and not in a specific @property def attr_name is so that we also get the better type with .get() and .as_dict().
  • Tweak system flags a bit
  • Add additional helper methods to NTDS for retrieving certain objects

@Schamper Schamper requested a review from joost-j April 17, 2026 16:09
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 246 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (69b8fb1) to head (c0e17da).

Files with missing lines Patch % Lines
dissect/database/ese/ntds/util.py 0.00% 69 Missing ⚠️
dissect/database/ese/ntds/objects/user.py 0.00% 37 Missing ⚠️
dissect/database/ese/ntds/objects/trusteddomain.py 0.00% 18 Missing ⚠️
dissect/database/ese/ntds/objects/object.py 0.00% 17 Missing ⚠️
...ct/database/ese/ntds/objects/organizationalunit.py 0.00% 15 Missing ⚠️
.../database/ese/ntds/objects/organizationalperson.py 0.00% 10 Missing ⚠️
dissect/database/ese/ntds/objects/computer.py 0.00% 9 Missing ⚠️
dissect/database/ese/ntds/objects/site.py 0.00% 9 Missing ⚠️
dissect/database/ese/ntds/ntds.py 0.00% 7 Missing ⚠️
...ssect/database/ese/ntds/objects/attributeschema.py 0.00% 6 Missing ⚠️
... and 14 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #55    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        150     150            
  Lines       4263    4475   +212     
======================================
- Misses      4263    4475   +212     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 17, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing ntds-more-attrs (c0e17da) with main (69b8fb1)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant