Fix detection of vdi harddisks inside a vbox file. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 61.61% 61.62% +0.01%
==========================================
Files 27 27
Lines 2355 2356 +1
==========================================
+ Hits 1451 1452 +1
Misses 904 904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sometimes the vbox configuration file might specifiy the format attribute of a HardDisk using lower case (vdi). This patch ensures that both lower and upper case are supported.
twiggler
force-pushed
the
fix/lowercase-disk-format
branch
from
8b38422 to
b9c4860
Compare
twiggler
commented
Sep 4, 2024
twiggler
commented
Sep 4, 2024
cecinestpasunepipe
previously approved these changes
Sep 5, 2024
Miauwkeru
previously requested changes
Sep 5, 2024
twiggler
dismissed
Miauwkeru’s stale review
I processed his comments and they are trivial
cecinestpasunepipe
previously approved these changes
Sep 5, 2024
Schamper
requested changes
Sep 6, 2024
Schamper
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the vbox configuration file might specifiy the format attribute of a HardDisk using lower case (vdi).
This patch ensures that both lower and upper case are supported.
Closes #43