Improve QCow2 to support automatic backing file resolution #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow the QCow2 constructor to accept a Path object for fh - If a backing file is detected, automatically attempt to open it relative to fh path's. Note: Providing a Qcow2 image with a backing file will work only if the fh is passed as a Path obj. Signed-off-by: Andreia Ocanoaia <andreia.ocanoaia@gmail.com>
This was referenced Jun 4, 2025
Schamper
requested changes
Jun 30, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 65.94% 66.06% +0.12%
==========================================
Files 24 24
Lines 2079 2066 -13
==========================================
- Hits 1371 1365 -6
+ Misses 708 701 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Signed-off-by: Andreia Ocanoaia <andreia.ocanoaia@gmail.com>
Schamper
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially solves this issue.
Pathobject for `fhNote: Providing a Qcow2 image with a backing file will work only if the fh is passed as a Path obj.