Handle NoneType in elastic adapter document_stream#155
Merged
yunzheng merged 1 commit intofox-it:mainfrom Jan 8, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 83.90% 83.85% -0.05%
==========================================
Files 34 34
Lines 3485 3487 +2
==========================================
Hits 2924 2924
- Misses 561 563 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Do you know which dissect plugin by any chance? It sounds like this should also be fixed there. |
yunzheng
approved these changes
Jan 8, 2025
Contributor
Author
|
We'll look into that in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
Unpackable type <class 'NoneType'>exception for the elastic adapter. This can occur when the record queue gets populated withNoneinstead of a record - which apparently can occur if for example a Dissect plugin does not return any records.