Skip to content

Fix version pinning for zstandard on pypy3.9#189

Merged
yunzheng merged 2 commits intomainfrom
bugfix/zstandard-pypy39
Aug 20, 2025
Merged

Fix version pinning for zstandard on pypy3.9#189
yunzheng merged 2 commits intomainfrom
bugfix/zstandard-pypy39

Conversation

@yunzheng
Copy link
Member

@yunzheng yunzheng commented Aug 20, 2025

Ordering matters to ensure that the pinned version takes precedence

Fixes #185

Ordering matters to ensure that the pinned version takes precedence 

Fixes #185
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.03%. Comparing base (04aec16) to head (0f744da).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   82.98%   83.03%   +0.05%     
==========================================
  Files          34       34              
  Lines        3602     3602              
==========================================
+ Hits         2989     2991       +2     
+ Misses        613      611       -2     
Flag Coverage Δ
unittests 83.03% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yunzheng
Copy link
Member Author

Looks to be an issue with tox, it doesn't respect the order and will sort it before passing to pip like:

pypy3: 3861 W install_package_deps> python -I -m pip install lz4 'msgpack>=0.5.2' 'tzdata; platform_system == "Windows"' zstandard 'zstandard==0.23.0; platform_python_implementation == "PyPy" and python_version == "3.9"' [tox/tox_env/api.py:461]

If the bare zstandard comes after the one with the constraint, it would work.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily we're dropping 3.9 support soon.

@yunzheng yunzheng merged commit 1dce701 into main Aug 20, 2025
25 checks passed
@yunzheng yunzheng deleted the bugfix/zstandard-pypy39 branch August 20, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installing zstandard 0.24.0 breaks on windows+pypy3.9

2 participants