Fix version pinning for zstandard on pypy3.9#189
Merged
Conversation
Ordering matters to ensure that the pinned version takes precedence Fixes #185
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 82.98% 83.03% +0.05%
==========================================
Files 34 34
Lines 3602 3602
==========================================
+ Hits 2989 2991 +2
+ Misses 613 611 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Looks to be an issue with tox, it doesn't respect the order and will sort it before passing to pip like: If the bare |
Schamper
approved these changes
Aug 20, 2025
Member
Schamper
left a comment
There was a problem hiding this comment.
Luckily we're dropping 3.9 support soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordering matters to ensure that the pinned version takes precedenceFixes #185