Add scheme matcher for routing on TLS state#97
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pawndev
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new built-in matcher to the existing list (alongside header, query, client IP) for routing on the request scheme.
The match is derived from
r.TLSonly. We deliberately don't look atr.URL.Schemebecause Go populates it from the request-line, which a client can set to anything via the HTTP/1.1 absolute-form (RFC 7230 §5.3.2). For example, sendingGET https://anything/path HTTP/1.1over plain TCP is a valid request that lands on the server withr.URL.Scheme == "https"whiler.TLS == nil. Same reasoning forX-Forwarded-Proto: it can be spoofed unless the application validates it within a trust boundary (e.g. trusted proxy list). When that's needed, users can write their ownMatcherand decide where the trust comes from.Example