Conversation
|
Hey @surendratiwari3, The build is failing. Please can you check it out? |
|
@subomi can you check now? |
|
@surendratiwari3 It seems the build still has problems. |
| Data: newMessage.Data, | ||
| Raw: newMessage.Raw, | ||
| Headers: e.getCustomHeaders(newMessage.CustomHeaders), | ||
| QueryParams: newMessage.QueryParams, |
There was a problem hiding this comment.
@surendratiwari3 I think It's better to limit this to the ingest path alone. I can't think of a good use-case for doing this via the API. Also, the contract will be confusing as to what is for our REST API and what should be proxied.
| ProjectID string `json:"project_id,omitempty" db:"project_id"` | ||
| Endpoints pq.StringArray `json:"endpoints" db:"endpoints"` | ||
| Headers httpheader.HTTPHeader `json:"headers" db:"headers"` | ||
| QueryParams url.Values `json:"query_params" bson:"query_params"` |
There was a problem hiding this comment.
@surendratiwari3 We switched to PostgreSQL as our default store, you need to switch this up for it to work.
subomi
left a comment
subomi
left a comment
There was a problem hiding this comment.
@surendratiwari3 The build is passing now, but I left some feedback. :)
|
|
|
Fixed in #1640 |
3 participants
This PR will add extension to convoy for sending query param received on ingest url to endpoint url. This will also store it in event and event_delivery document.
Referenced Issue
https://github.com/frain-dev/convoy/issues/1400
@subomi