Merged
Conversation
* update: add convertstringtojson function to general service * update: update monaco to accept custom class * feat: allow custom response setup for incoming sources * chore: remove console.log * update: ui fixes
Contributor
|
@Oluwadaminiola You can remove the supposed link to the custom response documentation here, we don't have any documentation for it. cc @subomi |
# Conflicts: # docs/docs.go # docs/swagger.json # docs/swagger.yaml # docs/v3/openapi3.json # docs/v3/openapi3.yaml
danvixent
force-pushed
the
daniel/fix/add_custom_response_to_source
branch
from
d480d99 to
cfb2cf7
Compare
…thub.com/frain-dev/convoy into daniel/fix/add_custom_response_to_source
…thub.com/frain-dev/convoy into daniel/fix/add_custom_response_to_source
subomi
requested changes
May 28, 2023
Collaborator
subomi
left a comment
subomi
left a comment
There was a problem hiding this comment.
@danvixent, @horlah FYI
- Updating a source does not update the custom response body.
- The update source form does not show the previously added response body but the previously added response content type.
…thub.com/frain-dev/convoy into daniel/fix/add_custom_response_to_source
subomi
approved these changes
May 28, 2023
|
EDIT: I opened an issue: #1947 Hello. Is it possible to template response using request header values? I want to solve okta's one-time verification request (https://developer.okta.com/docs/concepts/event-hooks/#one-time-verification-request) using convoy, but the challenge requires to respond with header value (x-okta-verification-challenge) . FYI, Okta requests with GET method for that challenge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.