Skip to content

Conversation

@fdlg
Copy link
Contributor

@fdlg fdlg commented Aug 12, 2021

This change brings in a few unit tests mainly checking that entry/exit handlers are called and that some transitions are correct

Four tests are disabled cause they're currently not passing, but left there as a reminder:

  • Entry handler isn't called for first state entered upon state machine creation
  • Parent entry handler isn't called when going from non-child state to child state
  • Parent exit handler isn't called when going from child state to a non-chilld state outside of parent
  • If child state has a even hadler for a give event, the parent's handler isn't called even if the childs handler doesn't result in a transition

We should probably track them separately

Fernando De la Garza added 10 commits August 11, 2021 21:32
…d_code),

allow(non_snake_case) and allow(unused_imports) to silence warnings when
compiling generated code
clippy upper case acronyms and needless return check
FrameMessage in generated code and instead implement fmt::Display
trait which then provides a to_string implementation
compiler warnings about snake/camel casing and unnecesary parenthesis usage
@frame-lang frame-lang merged commit a042deb into frame-lang:main Aug 12, 2021
frame-lang pushed a commit that referenced this pull request Sep 29, 2025
- Fixed action calls being generated as global functions instead of instance methods
- Added action_names tracking to PythonVisitorV2
- Collect action names BEFORE processing machine block for proper resolution
- Action calls now correctly generate self.__SystemName__actionName syntax
- Test test_return_assign_actions.frm now passes

Test Results:
- Before: 372/376 tests passing (98.9%)
- After: 373/376 tests passing (99.2%)
- Only 2 runtime failures remaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants