Init 3rd-party-optimizer plugin#392
Merged
kurtextrem merged 28 commits intomainfrom Sep 8, 2025
Merged
Conversation
f9ba875 to
3b7f77f
Compare
c9159ee to
9f0fe3d
Compare
alecmev
reviewed
Sep 1, 2025
This reverts commit 429a5a0.
alecmev
reviewed
Sep 2, 2025
alecmev
approved these changes
Sep 3, 2025
Contributor
alecmev
left a comment
There was a problem hiding this comment.
Nice! Thanks for the patience! 🙏😌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the 3rd-party-optimizer plugin.
I've introduced a
VITE_CONFIG_PATHenv var which plugins can set if they need to extend the global vite config in this repo. I use it to compile the yieldGTMCalls script with esbuild so the import becomes an inline import. It must be processed so that it becomes minified / JS, so e.g.?rawcan't be used.I updated yarn as well, because it's just a minor bump. The rest comes from running
yarn dedupe. Interestingly, this lead to new TS type & eslint errors, where e.g.await framer.closePluginstarted erroring.Testing