Global Search: Order Results and Search Menu items#402
Merged
elmarburke merged 3 commits intomainfrom Sep 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements consistent ordering for search results and menu items in the Global Search plugin. The ordering prioritizes Pages, Collections, and Components in that sequence across both result display and the search menu interface.
- Adds a sorting mechanism to group search results by type with a predefined order
- Updates the search menu to display options in the same consistent order
- Removes a hardcoded width constraint from the context menu
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| group-results.ts | Implements result sorting with a new comparison function and predefined order array |
| Menu.tsx | Removes hardcoded width constraint from context menu |
| SearchScene.tsx | Sorts menu items using the same ordering logic as search results |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alecmev
approved these changes
Sep 1, 2025
elmarburke
force-pushed
the
global-search/order-results
branch
from
e38f3ec to
53080e3
Compare
elmarburke
force-pushed
the
global-search/order-results
branch
from
53080e3 to
753df04
Compare
Contributor
|
QA is ✅ btw 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Orders the Results and the Search Menu items in the following order:
Testing