Skip to content

Global search: Group Header Height#462

Merged
elmarburke merged 2 commits intomainfrom
global-search/group-header-height
Oct 1, 2025
Merged

Global search: Group Header Height#462
elmarburke merged 2 commits intomainfrom
global-search/group-header-height

Conversation

@elmarburke
Copy link
Copy Markdown
Contributor

@elmarburke elmarburke commented Sep 30, 2025

Description

  • Adjust the height of the headers to the height of the sidebar.
image

Testing

  • Collapsed headers have the same height as in the sidebar

Note

Use CSS variables to control header and item heights and update virtualization and header styling to match sidebar dimensions.

  • Global Search UI:
    • Virtualization (plugins/global-search/src/components/Results.tsx):
      • estimateSize now uses computed CSS variables --header-height and --item-height (with fallbacks) instead of hardcoded values.
      • Sticky header rows receive inline height from the virtualizer.
    • Styling:
      • Define --header-height and --item-height in plugins/global-search/src/styles.css.
    • Group Header (plugins/global-search/src/components/GroupHeader.tsx):
      • Replace fixed heights with calc-based sizing tied to --header-height.
      • Adjust fade-out pseudo-element position to top-(--header-height).
      • Change hidden hr styling to use modal border colors instead of opacity.

Written by Cursor Bugbot for commit 9957563. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

Comment thread plugins/global-search/src/components/Results.tsx Outdated
@elmarburke elmarburke force-pushed the global-search/group-header-height branch from 9957563 to c0197a6 Compare September 30, 2025 09:40
@elmarburke elmarburke requested a review from triozer September 30, 2025 09:44
Comment thread plugins/global-search/src/components/GroupHeader.tsx
Copy link
Copy Markdown
Member

@triozer triozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elmarburke elmarburke added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit e933634 Oct 1, 2025
7 checks passed
@elmarburke elmarburke deleted the global-search/group-header-height branch October 1, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants