Skip to content

Issue 8/pass ci polars skip#4

Open
frank113 wants to merge 17 commits intodevfrom
issue_8/pass_ci_polars_skip
Open

Issue 8/pass ci polars skip#4
frank113 wants to merge 17 commits intodevfrom
issue_8/pass_ci_polars_skip

Conversation

@frank113
Copy link
Copy Markdown
Owner

No description provided.

@frank113
Copy link
Copy Markdown
Owner Author

frank113 commented Oct 22, 2023

Test failure indicates that numeric functionality is broken -- this will be fixed at this time:

https://github.com/frank113/pycountrycode/actions/runs/6601786567

Specific issue is that getting the data directly from codelist results in the value being a string of a number rather than a number. Specific failure:

   AssertionError: assert 124 == '124'
   +  where 124 = countrycode('CAN', 'iso3c', 'iso3n')
Falsifying explicit example: test_numeric(
     code_param='CAN',
 )

Decision: Bring it up with Vincent in the PR, propose leaving it as is for now, file issue than fix issue separately. critical for tests to pass as the package is live -- other issues can be fixed later.

@frank113
Copy link
Copy Markdown
Owner Author

frank113 commented Nov 2, 2023

In test_conversion_polars the numeric test fails when using the dictionary representation of codelist. When creating the PR to upstream call this out and suggest sunsetting the polars tests entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant