refactor: remove dead leaf modules (v1 domain cleanup, part 1)#598
Merged
Conversation
Delete confirmed zero-importer dead modules + their tests:
- core/{credential_audit,credential_validator,phase_manager,project_status}.py
- git/github_issue_sync.py, lib/{quality_gate_tool,sdk_hooks}.py
- ui/auth.py, agents/subagent_generator.py
- notifications/{router,desktop}.py (legacy desktop notifications; live
webhook notifications are unaffected)
- codeframe/tasks/ and codeframe/context/ (empty/dead packages)
- codeframe/persistence/database.py.backup (committed junk)
- 12 test files covering the above; trimmed the github_issue_sync section
out of the still-live tests/core/test_reconciliation.py
Verified: no dangling refs, app boots (TestClient lifespan /health 200),
collection clean, full -m v2 green (2920 passed, 0 failed).
The tangled v1 domain cluster (multi-agent lead/worker classes, core/project,
and the deployment/discovery/enforcement/indexing/providers/testing dirs they
pull in, plus the Database-class method slimming) remains for a dedicated
follow-up — it's kept reachable via agents/__init__ and cli/__init__ and needs
careful untangling.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (28)
💤 Files with no reviewable changes (25)
WalkthroughThis pull request removes multiple deprecated and superseded modules across the codebase. The removals span agent generation, credential validation, phase management, project status tracking, notification systems, quality gate tooling, GitHub issue synchronization, and a deprecated authentication module. Associated test files covering these features are also deleted, with two explicit test cleanup ranges documented. ChangesFeature and Module Cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Review — PR #598: Dead leaf module removal (v1 cleanup, part 1)Summary: Pure deletion PR — 15 source files + 12 test files + 1 surgical test edit, ~11.6k lines removed, 0 added. The validation story in the PR description is solid and this is clearly safe to merge. What's done well
One functional question to documentBlocker expiration: Is this functionality now covered in v2? A quick check of Minor observations
OverallClean execution of the CLAUDE.md roadmap. The remaining v1 domain cluster ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of the v1 removal (after #596 serve fix, #597 web layer). Removes confirmed zero-importer dead modules + their tests (~11.6k lines). Every target was verified to have no live importer (reachability graph from
cli/app.py+ui/server.py, plus exact-path grep).Deleted
core/{credential_audit, credential_validator, phase_manager, project_status}.pygit/github_issue_sync.py,lib/{quality_gate_tool, sdk_hooks}.pyui/auth.py,agents/subagent_generator.pynotifications/{router, desktop}.py— legacy desktop notifications; the live webhook notifications (Phase 5.3) are untouchedcodeframe/tasks/andcodeframe/context/— empty/dead packagescodeframe/persistence/database.py.backup— committed junkgithub_issue_syncsection from the still-livetests/core/test_reconciliation.pyValidation
codeframe/(non-test).TestClient(app)lifespan →/health200.pytest --collect-only→ 0 errors, 5081 collected).uv run pytest -m v2→ 2920 passed, 0 failed.Still remaining (dedicated follow-up)
The tangled v1 domain cluster — the multi-agent
lead_agent/worker_agent/factoryclasses,core/project, and thedeployment/discovery/enforcement/indexing/providers/testingdirs they import — is kept "reachable" viaagents/__init__.pyandcli/__init__.py. Removing it requires cutting those__init__threads first and confirming no livecfcommand uses the old multi-agent execution model, then deleting the cluster + slimming theDatabaseclass methods. Plus PR 4: renamepersistence/→platform_store/and fix CLAUDE.md's stale repo-structure notes.Kept (live): E2B cloud exec, worktree sandbox,
cf dashboardTUI,agents/dependency_resolver, live webhook notifications, the slim global control-plane DB.Summary by CodeRabbit