ci(e2e): formally defer Playwright browser E2E + fix legacy comments (#647)#685
Conversation
…647) The two browser-level Playwright jobs (e2e-smoke-tests, e2e-frontend-tests) were commented out with "web-ui is legacy during v2 CLI-first refactor" — contradicting CLAUDE.md (web UI is actively developed). They can't simply be re-enabled: the tests/e2e/*.spec.ts suite targets a /projects/[id] route architecture the current Phase-3+ workspace UI no longer has (19/19 specs reference /projects; navigates to /projects/${id} 36+ times), so it fails as-is. Formally defer instead of leaving a misleading disable: - Remove the 326 lines of stale commented-out job bodies (preserved in git history); replace with a concise deferral note referencing the rewrite issue. - Correct the schedule-cron comment and remove the "legacy" claim. - Rewrite tracked in #684. No functional CI change (jobs were already not running); test-summary wiring unchanged. The remaining "legacy" reference (line ~250) is about v1 Python modules, not the web UI. Closes #647
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe CI workflow's commented-out Playwright browser-level E2E job stanzas (smoke and all-browsers, ~300 lines) are removed and replaced with a short comment block formally deferring the suite, referencing issue ChangesPlaywright E2E Deferral
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Closes #647 (P6.5.2). Two browser-level Playwright E2E jobs were commented out with a "web-ui is legacy during v2 CLI-first refactor" rationale that contradicts CLAUDE.md (the web UI is actively developed). Per the issue, the fix is to either re-enable or formally defer them.
Decision: formally defer — re-enabling is infeasible in this issue's scope. The
tests/e2e/*.spec.tssuite targets a/projects/[id]route architecture the current Phase-3+ workspace UI no longer has, so it cannot pass as-is and needs a rewrite (not a fix).Evidence the suite is stale
/projects; specspage.goto('.../projects/${PROJECT_ID}')36+ times, plus/signup,/projects/1./,/prd,/tasks,/execution,/blockers,/proof,/review,/sessions,/settings,/costs,/login— no/projects,/dashboard,/metrics,/signup.tests/e2e/E2E_TEST_AUDIT.md(2026-01-09) describes login redirecting to/projects— stale.Changes
e2e-smoke-tests,e2e-frontend-tests); preserved in git history. Replaced with a concise, accurate DEFERRED note referencing the rewrite issue.schedule:cron comment to state why it's off.legacyreference (test-scoping note, line ~250) is about v1 Python modules, not the web UI.Verification
code-quality, check-hardcoded-urls, backend-tests, frontend-tests, e2e-backend-tests, testsprite-e2e, test-summary.test-summary.needsunchanged (deferred jobs were never wired in).Acceptance criteria
Known limitations
Browser E2E coverage remains off until #684 lands. Jest unit tests + the new
npm run buildgate (#646) remain the UI safety net in the meantime.Summary by CodeRabbit