Open
Conversation
This was
linked to
issues
Feb 4, 2026
stijnpotters1
force-pushed
the
feat/jump-buttons
branch
from
8efbef6 to
dbfec23
Compare
|
Daan0709
requested changes
Feb 4, 2026
Contributor
Daan0709
left a comment
Daan0709
left a comment
There was a problem hiding this comment.
I prefer buttons having a pointer cursor when hovering over it, but looks good for the rest. I like how it keeps track of the cursor to open the correct adapter from the editor!
| <span>Path: {activeTabFilePath}</span> | ||
| <button | ||
| onClick={handleOpenInStudio} | ||
| className="border-border bg-background hover:bg-foreground-active flex items-center gap-1.5 rounded border px-2.5 py-1 text-sm" |
Contributor
There was a problem hiding this comment.
Suggested change
| className="border-border bg-background hover:bg-foreground-active flex items-center gap-1.5 rounded border px-2.5 py-1 text-sm" | |
| className="border-border bg-background hover:bg-foreground-active flex items-center gap-1.5 rounded border px-2.5 py-1 text-sm hover:cursor-pointer"" |
| <span>Path: {activeTabPath}</span> | ||
| <button | ||
| onClick={handleOpenInEditor} | ||
| className="border-border bg-background hover:bg-foreground-active flex items-center gap-1.5 rounded border px-2.5 py-1 text-sm" |
Contributor
There was a problem hiding this comment.
Suggested change
| className="border-border bg-background hover:bg-foreground-active flex items-center gap-1.5 rounded border px-2.5 py-1 text-sm" | |
| className="border-border bg-background hover:bg-foreground-active flex items-center gap-1.5 rounded border px-2.5 py-1 text-sm hover:cursor-pointer"" |
philipsens
reviewed
Feb 4, 2026
| Path: {activeTabFilePath} | ||
| <div className="border-b-border bg-background flex h-12 items-center justify-between border-b p-4"> | ||
| <span>Path: {activeTabFilePath}</span> | ||
| <button |
Member
There was a problem hiding this comment.
Why not use the button component?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.