Now attributes are setted when dragging an element on the canvas#383
Now attributes are setted when dragging an element on the canvas#383stijnpotters1 wants to merge 1 commit intomasterfrom
Conversation
stijnpotters1
commented
Mar 24, 2026
|
Matthbo
left a comment
There was a problem hiding this comment.
Does this set all attributes or only the required ones?
Wat about inherited attributes from the parent?
The FF Doc website has ways to recursively go through all the parents and collect their required attributes to be shown on the element details page and syntax. That should also be done here as those attributes must be set
It sets all the attributes that are associated with the element from the frankdoc. There was an issue where dragging an element from the palette showed the wrong attributes (ones that did not even belong to said element). I think I broke that a couple weeks ago, since it used to just work. This PR adresses that issue. But you're right, I don't believe it gathers the inherited attributes from the parents yet, since it had never done this. That would be a nice addition |


