Skip to content

Now attributes are setted when dragging an element on the canvas#383

Open
stijnpotters1 wants to merge 1 commit intomasterfrom
fix/element-canvas-drop
Open

Now attributes are setted when dragging an element on the canvas#383
stijnpotters1 wants to merge 1 commit intomasterfrom
fix/element-canvas-drop

Conversation

@stijnpotters1
Copy link
Contributor

image

@sonarqubecloud
Copy link

Copy link
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this set all attributes or only the required ones?
Wat about inherited attributes from the parent?

The FF Doc website has ways to recursively go through all the parents and collect their required attributes to be shown on the element details page and syntax. That should also be done here as those attributes must be set

@Daan0709
Copy link
Contributor

Does this set all attributes or only the required ones? Wat about inherited attributes from the parent?

The FF Doc website has ways to recursively go through all the parents and collect their required attributes to be shown on the element details page and syntax. That should also be done here as those attributes must be set

It sets all the attributes that are associated with the element from the frankdoc. There was an issue where dragging an element from the palette showed the wrong attributes (ones that did not even belong to said element). I think I broke that a couple weeks ago, since it used to just work. This PR adresses that issue.

But you're right, I don't believe it gathers the inherited attributes from the parents yet, since it had never done this. That would be a nice addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding element from palette loads in the wrong attributes

3 participants