Skip to content

Refactor file selection logic in git changes #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stijnpotters1 merged 1 commit into from
Apr 22, 2026
Merged

Refactor file selection logic in git changes #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/main/frontend/app/components/git/git-changes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,14 @@ function FileSection({
)}
onClick={() => onSelectFile(file)}
>
<IndeterminateCheckbox
checked={checkboxChecked}
indeterminate={checkboxIndeterminate}
onChange={() => onToggleFile(file)}
title={checkboxChecked ? 'Deselect all chunks' : 'Select all chunks'}
/>
<div onClick={(e) => e.stopPropagation()}>
<IndeterminateCheckbox
checked={checkboxChecked}
indeterminate={checkboxIndeterminate}
onChange={() => onToggleFile(file)}
title={checkboxChecked ? 'Deselect all chunks' : 'Select all chunks'}
/>
</div>
<span
className={clsx(
'flex h-4 w-4 flex-shrink-0 items-center justify-center rounded text-[10px] font-bold',
Expand Down
9 changes: 5 additions & 4 deletions src/main/frontend/app/components/git/git-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,14 @@ export default function GitPanel({ projectName, hasStoredToken }: GitPanelProps)
)

const handleToggleFile = useCallback(
(filePath: string) => {
async (filePath: string) => {
const hunkState = useGitStore.getState().fileHunkStates[filePath]
if (!hunkState || hunkState.totalHunks === 0) {
handleSelectFile(filePath)
return
await handleSelectFile(filePath)
}
if (hunkState.selectedHunks.size === hunkState.totalHunks) {

const updatedState = useGitStore.getState().fileHunkStates[filePath]
if (updatedState.selectedHunks.size === updatedState.totalHunks) {
clearFileHunks(filePath)
} else {
selectAllFileHunks(filePath)
Expand Down
Loading