Add glyph for Frank elements and implemented in Editor" functionality#467
Open
stijnpotters1 wants to merge 1 commit intomasterfrom
Open
Add glyph for Frank elements and implemented in Editor" functionality#467stijnpotters1 wants to merge 1 commit intomasterfrom
stijnpotters1 wants to merge 1 commit intomasterfrom
Conversation
… in Editor" functionality
This was
linked to
issues
May 6, 2026
|
Member
|
:D Looks nice! |
philipsens
reviewed
May 8, 2026
| return 1 | ||
| } | ||
|
|
||
| export function findElementInXml(xml: string, subtype: string, name?: string): number | null { |
Member
There was a problem hiding this comment.
I was wondering, since I haven't always been reviewing. How is the parsing of the XML done when generating the nodes? Is done once, or let's say, on every update? The latter was true for the old frank-flow. I don't think that was ideal, but since we did that anyway, I would save the location of each parsed pipe, so when I wend to highlight it, I would already know the location. Would something like that be possible here too? Or is this needed because there is no extra parse taking place?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added glyph and when going from studio to editor the element is highlighted
When from editor to studio the element is centered and selected