Skip to content

bug: standalone "migrate" doesn't seem to enable maintenance mode #37

@ankush

Description

@ankush

Screenshot 2022-09-08 at 7 32 58 PM

Based on this code, it seems it directly issues migrate. I am not entirely sure if this is handled somewhere else.

agent/agent/site.py

Lines 374 to 379 in 6ea14dd

@step("Migrate Site")
def migrate(self, skip_failing_patches=False):
if skip_failing_patches:
return self.bench_execute("migrate --skip-failing")
else:
return self.bench_execute("migrate")

This was fine before because patch and doctype schemas had their own ad-hoc maintenance mode that blocked writes. But that's going away now with frappe/frappe@8c7d6ab

Additionally, that ad-hoc maintenance mode only covers doctype schema and patches. So this bug needs to be fixed regardless of the linked PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions