Skip to content

fix(pageMeta): Don't access document in top-level#207

Closed
cogk wants to merge 1 commit intofrappe:mainfrom
cogk:patch-1
Closed

fix(pageMeta): Don't access document in top-level#207
cogk wants to merge 1 commit intofrappe:mainfrom
cogk:patch-1

Conversation

@cogk
Copy link

@cogk cogk commented Oct 23, 2024

Improve compatibility with tools that set the document global to undefined while pre-rendering/SSR (e.g. Nitro).

https://stackoverflow.com/questions/46058544/document-is-not-defined-in-nuxt-js

@netlify
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for frappeui ready!

Name Link
🔨 Latest commit 4e55352
🔍 Latest deploy log https://app.netlify.com/sites/frappeui/deploys/6718f7c3676ad100088be50f
😎 Deploy Preview https://deploy-preview-207--frappeui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netchampfaris
Copy link
Contributor

@cogk

Hey are you able to use frappe-ui in a nuxt project with this change?

@netchampfaris
Copy link
Contributor

7e7244d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants