Added URL Argument to Call method#239
Closed
FeezyHendrix wants to merge 2 commits intofrappe:mainfrom
Closed
Conversation
✅ Deploy Preview for frappeui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
surajshetty3416
requested changes
Nov 10, 2025
|
|
||
| // Allow custom path override using the url args | ||
| if (args.url) { | ||
| path = url + path; |
Member
There was a problem hiding this comment.
Suggested change
| path = url + path; | |
| path = args.url + path; |
?
Member
|
Looks like untested PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The current
callmethod is limited to using a fixed base URL. It does not support sending requests to a different hostname or port, which restricts its flexibility in multi-environment or distributed system setups.Solution:
This update introduces the
urlkey as an optional parameter in thecallmethod. When provided, the process constructs the request URL using the specified hostname and port. If theURLkey is omitted, the method defaults to the existing base URL.Usage Example:
This resolves the request to: