Use label to identify pods belonging to the Frappe deployment#268
Merged
revant merged 5 commits intofrappe:mainfrom Feb 4, 2026
Merged
Use label to identify pods belonging to the Frappe deployment#268revant merged 5 commits intofrappe:mainfrom
revant merged 5 commits intofrappe:mainfrom
Conversation
Contributor
Author
|
@revant any chance to review and merge this? Not sure about the failed check, looks like it's not related to these changes. Let me know if you need any more information. |
Collaborator
|
https://github.com/frappe/helm/blob/main/CONTRIBUTING.md#run-pre-commit Run this and commit the changes. That'll fix lint failures. |
Contributor
Author
|
@revant sorry, should have read that before. Branch is now up-to-date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the Kubernetes-based deployment of ERPNext requires RWX volumes, it's rather difficult to deploy on a cluster where the infrastructure provider does not offer such volumes. NFS is a workaround but also difficult to deploy right in a production environment. Due to this, IMHO it's a valid option to place all ERPNext pods on one single node which allows so share a usual RWO volume.
This scheduling can be achived using
(The same has to be applied for all deployments, nginx is used as an example here)
This MR adds a common label to all pods, as this is required for this kind of affinity.