fix: Submit Feedback button in interview#2412
Closed
Nihantra-Patel wants to merge 1 commit intofrappe:developfrom
Closed
fix: Submit Feedback button in interview#2412Nihantra-Patel wants to merge 1 commit intofrappe:developfrom
Nihantra-Patel wants to merge 1 commit intofrappe:developfrom
Conversation
Member
|
@Nihantra-Patel I think the before and after videos are same |
Member
Author
|
No, In "After" video, once you Submit Feedback then button will disappear. |
ruchamahabal
reviewed
Dec 4, 2024
| frm.page.set_primary_action(__("Submit Feedback"), () => { | ||
| frm.trigger("submit_feedback"); | ||
| }); | ||
| frappe.db |
Member
There was a problem hiding this comment.
Interview Feedback can be submitted by multiple interviewers. This just checks for a single feedback. So even if 1 interviewer has submitted the feedback, the next one won't see a button at all. Should also check if submitted feedback's interviewer is the session user.
Member
|
Resolved by #2921 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2401
Before:
before_interview.webm
After:
after_interview.webm