fix: disable leave application against expired allocations#2463
Closed
AyshaHakeem wants to merge 3 commits intofrappe:developfrom
Closed
fix: disable leave application against expired allocations#2463AyshaHakeem wants to merge 3 commits intofrappe:developfrom
AyshaHakeem wants to merge 3 commits intofrappe:developfrom
Conversation
ruchamahabal
reviewed
Dec 6, 2024
| & (Ledger.transaction_type == "Leave Allocation") | ||
| & (Ledger.employee == employee) | ||
| & (Ledger.is_expired == 0) | ||
| & (LeaveAllocation.expired == 0) |
Member
There was a problem hiding this comment.
Ledger getting expired and allocation getting expired is the same right? How does the earlier one not work?
Collaborator
Author
There was a problem hiding this comment.
Expired leaves were still shown despite the ledger filter applied
Collaborator
Author
|
When a Leave Allocation is marked as expired, a Leave Ledger Entry is created with a negative value for unused leaves and 'is_expired' checked, while previously submitted entries remain unchanged. The filter excluding expired entries when fetching allocated leaves has now been removed for accurate leave balance calculation. |
Member
|
Fixed by #3335, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where employees could apply for leaves marked as expired. Updated the condition to exclude expired leave allocations when fetching available leaves.
Before:
After:
