fix(ux): Set from_date or to_date automatically in Leave Application if to_date < from_date #2862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the from_date is later than the to_date, or the other way around - set the least-value instead of simply unsetting it. Show an alert for the same.
Member
ruchamahabal
left a comment
ruchamahabal
left a comment
There was a problem hiding this comment.
Showing the alert is cool but setting the date and showing the alert both can be confusing for the user, maybe? 🙈
User might think they selected 4th on from and to both and still got the message
Contributor
Author
|
I'd thought of adding a subsequent alert indicating the updated field value:
But @marination suggested reducing the noise and just highlighting the change simply since nobody deliberately tries to set the
|
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
ruchamahabal
approved these changes
Apr 14, 2025
ruchamahabal
added a commit
that referenced
this pull request
Apr 14, 2025
…2862 fix(ux): Set from_date or to_date automatically in Leave Application if to_date < from_date (backport #2862)
ruchamahabal
added a commit
that referenced
this pull request
Apr 14, 2025
…2862 fix(ux): Set from_date or to_date automatically in Leave Application if to_date < from_date (backport #2862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the from_date is later than the to_date, or the other way around - set the least-value instead of simply unsetting it. Show an alert for the same.