fix: add missing applicant_type field#315
Closed
elshafei-developer wants to merge 55 commits intofrappe:developfrom
elshafei-developer:develop
Closed
fix: add missing applicant_type field#315elshafei-developer wants to merge 55 commits intofrappe:developfrom elshafei-developer:develop
elshafei-developer wants to merge 55 commits intofrappe:developfrom
elshafei-developer:develop
Conversation
* chore: better loan partner validations and some field changes * chore: fix linting issues
* fix: post install patches * chore: fix linting issues * chore: make patches more fail-safe
- skip cancelled loans for patch
…chedule fix: patch generate loan repayment schedule failing
feat: Loan Adjustment doctype
chore: Add loan npa log doctype
rename loan partner
…partner Revert "rename loan partner"
fix: Remove charges receivable GL Entries
fix: apply company filter on employee applicant field
fix: Loan Disbursement doc in bank reco
fix: remove company filter from customer and member in applicant field
fix: Loan Reco updates
…t_matching_queries fix: typeerror on Bank Reconciliation tool
fix: Loan Interest Accrual cancellation
test: Update loan account type
…ing_cost_account field
…lose_loan flag to loan closure method
fix: adjust amount exceeding due limit to principal paid
…unt_v15 fix: if pending_principal_amount and not repayment_details
…lacement Fix: Proper Placement of Loan tab in Company DocType
fix: auto-close loan on repayment for employee applicants, add auto_close_loan flag to loan closure method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in
status = "Closed" if loan.applicant_type == "Employee" else "Loan Closure Requested"lineloan.applicant_typeis used to determine if loan is for employee and then close it but the value is not loaded inloan = frappe.get_valuePlease
backport version-15