refactor: Settings#172
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the settings functionality by removing obsolete components and introducing new features for profile editing and password changes.
- Removed the deprecated UserSettings and MailAccountSettings components.
- Introduced new components for Profile, Account, and Advanced settings, along with modals for editing photos and changing passwords.
- Updated various FormControl usages by removing the explicit type attributes and adjusted modal sizes and layouts.
Reviewed Changes
Copilot reviewed 30 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| BusinessSignupView.vue | Removed redundant type attributes in verification and name forms |
| UserSettings.vue & MailAccountSettings.vue | Removed obsolete settings components |
| ProfileSettings.vue, AdvancedSettings.vue, AccountSettings.vue | Added new settings components with updated behavior |
| SettingsModal.vue | Updated modal layout and tabs mapping to new settings components |
| EditPhotoModal.vue, ChangePasswordModal.vue | Introduced new modals for profile photo edits and password changes |
| AddMemberModal.vue, AddGroupModal.vue, AddDomainModal.vue, AddAliasModal.vue | Removed type attributes from FormControl for consistency |
| MailThread.vue, EmojiPicker.vue, CopyControl.vue | Minor attribute and styling updates |
| index.html | Removed inline CSRF token script |
Files not reviewed (3)
- frappe-ui: Language not supported
- frontend/package.json: Language not supported
- frontend/src/index.css: Language not supported
Comments suppressed due to low confidence (1)
frontend/index.html:13
- The removal of the inline CSRF token script might affect security if an alternative CSRF token provision isn't implemented. Please ensure CSRF protection is still handled appropriately.
<script> window.csrf_token = '{{ csrf_token }}'; </script>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #165
Features
Before: #42
Now: