feat: setting to disable push notification for mailbox#418
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds per-mailbox control over push notifications so users can disable notifications for specific subscribed mailboxes.
Changes:
- Adds
disable_push_notificationcheckbox to the Mailbox Settings DocType. - Updates push-notification candidate selection to include all subscribed mailboxes (and exclude disabled ones).
- Introduces
MailboxService.is_subscribed()helper to check mailbox subscription status.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
mail/jmap/services/mail/mailbox.py |
Adds an is_subscribed() helper used by notification logic. |
mail/client/doctype/mailbox_settings/mailbox_settings.json |
Adds a new checkbox field to disable push notifications per mailbox. |
mail/client/doctype/mail_message/mail_message.py |
Updates notification eligibility and mailbox reload publishing based on subscription + new disable setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, push notifications are now enabled for all subscribed mailboxes (except drafts and junk). Set the
disable_push_notificationto1to disable notifications for the specific mailbox.