Skip to content

Conversation

@Aradhya-Tripathi
Copy link
Contributor

@Aradhya-Tripathi Aradhya-Tripathi commented Apr 7, 2025

Known Issues:

  • Preparing status not set correctly.
  • Which docker image to deploy.

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 31.77215% with 539 lines in your changes missing coverage. Please review.

Project coverage is 35.03%. Comparing base (96ddf86) to head (c3c47bc).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
...e/deploy_candidate_build/deploy_candidate_build.py 30.14% 475 Missing ⚠️
...press/doctype/deploy_candidate/deploy_candidate.py 23.72% 45 Missing ⚠️
...s/doctype/deploy_candidate/deploy_notifications.py 45.45% 12 Missing ⚠️
press/press/doctype/deploy/deploy.py 50.00% 2 Missing ⚠️
press/agent.py 0.00% 1 Missing ⚠️
press/press/doctype/agent_job/agent_job.py 50.00% 1 Missing ⚠️
press/press/doctype/app_release/app_release.py 0.00% 1 Missing ⚠️
.../doctype/deploy_candidate/docker_output_parsers.py 91.66% 1 Missing ⚠️
...ress/press/doctype/deploy_candidate/validations.py 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (31.77%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2587      +/-   ##
==========================================
+ Coverage   34.90%   35.03%   +0.12%     
==========================================
  Files         418      419       +1     
  Lines       33502    33569      +67     
==========================================
+ Hits        11693    11760      +67     
  Misses      21809    21809              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aradhya-Tripathi Aradhya-Tripathi changed the title feat: Separate build doctype feat(builds): Separate build doctype Apr 11, 2025
@Aradhya-Tripathi Aradhya-Tripathi marked this pull request as ready for review April 14, 2025 06:50
@Aradhya-Tripathi Aradhya-Tripathi merged commit 0db6bb6 into master Apr 22, 2025
3 of 5 checks passed
@Aradhya-Tripathi Aradhya-Tripathi deleted the at/builds branch April 22, 2025 16:50
@Aradhya-Tripathi Aradhya-Tripathi restored the at/builds branch April 23, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants