Skip to content

fix(dedicated-site-plan): Bug fixes#6455

Merged
regdocs merged 6 commits into
release/2026-W21from
develop
May 18, 2026
Merged

fix(dedicated-site-plan): Bug fixes#6455
regdocs merged 6 commits into
release/2026-W21from
develop

Conversation

@regdocs
Copy link
Copy Markdown
Member

@regdocs regdocs commented May 18, 2026

No description provided.

@regdocs regdocs requested a review from siduck as a code owner May 18, 2026 06:15
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 18, 2026

Greptile Summary

This PR fixes a UX bug in ManageProductWarrantyDialog.vue where the Switch toggle was incorrectly disabled when the dialog first opened. Previously the Switch used disablePrimaryAction — a combined condition that disabled the control if the toggle value matched the current plan state OR if the change cooldown hadn't expired. Since the toggle always starts matching the current state, the Switch was permanently disabled on open, preventing users from making any change.

  • Fix: The Switch's :disabled binding is decoupled from disablePrimaryAction and now only checks the cooldown (nextChangeAvailableOn !== 'Available Now'). The Save button retains the full disablePrimaryAction guard (no-op change OR in-cooldown), so saving a no-op is still prevented.

Confidence Score: 5/5

Safe to merge — the change is a targeted one-line fix that correctly separates the Switch's interactability from the Save button's submit guard.

The fix correctly identifies that the Switch toggle and the Save button serve different UX roles: the toggle should be interactive whenever the cooldown has expired, while the Save button should additionally block no-op submissions. The disablePrimaryAction guard on the Save button is untouched and still enforces both conditions. No regressions are introduced.

No files require special attention.

Important Files Changed

Filename Overview
dashboard/src/components/ManageProductWarrantyDialog.vue Single-line fix decoupling the Switch disabled state from disablePrimaryAction; Save button guard unchanged and correct.

Reviews (1): Last reviewed commit: "Merge pull request #6454 from frappe/fix..." | Re-trigger Greptile

@regdocs regdocs merged commit ab1ff72 into release/2026-W21 May 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant