Skip to content

fix: wiki user unable to view editor sidebar#526

Merged
NagariaHussain merged 1 commit intofrappe:developfrom
vishwajeet-13:fix/sidebar-content
Feb 17, 2026
Merged

fix: wiki user unable to view editor sidebar#526
NagariaHussain merged 1 commit intofrappe:developfrom
vishwajeet-13:fix/sidebar-content

Conversation

@vishwajeet-13
Copy link
Collaborator

@vishwajeet-13 vishwajeet-13 commented Feb 17, 2026

Added Ignore permissions not sidebar content is visible
Screenshot 2026-02-17 at 11 32 41 AM

Summary by CodeRabbit

  • Bug Fixes
    • Improved wiki revision operations to work correctly in restricted permission contexts.

@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026

Walkthrough

The changes update two insert() operations in the Wiki Revision system by adding the ignore_permissions=True parameter. The first modification occurs in create_overlay_revision after copying base revision metadata, and the second in ensure_overlay_item when copying an item into an overlay revision. The underlying control flow and error-handling logic remain unchanged.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'fix: wiki user unable to view editor sidebar' describes a user-facing issue, but the changeset only adds ignore_permissions flags to two insert() calls in wiki_revision.py without modifying sidebar or editor components. Change the title to better reflect the actual code change, such as 'fix: bypass permission checks when creating overlay revisions' or 'fix: add ignore_permissions to overlay revision operations'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NagariaHussain NagariaHussain changed the title fix: add ignore permission fix: wiki user unable to view editor sidebar Feb 17, 2026
@NagariaHussain NagariaHussain merged commit 12b3c24 into frappe:develop Feb 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants