Skip to content

revert: bubble menu hidden behind sticky toolbar#545

Merged
NagariaHussain merged 1 commit intofrappe:developfrom
gajjug004:revert/bubble-menu-sticky-toolbar-540
Feb 18, 2026
Merged

revert: bubble menu hidden behind sticky toolbar#545
NagariaHussain merged 1 commit intofrappe:developfrom
gajjug004:revert/bubble-menu-sticky-toolbar-540

Conversation

@gajjug004
Copy link
Collaborator

@gajjug004 gajjug004 commented Feb 18, 2026

Issue

image image
  • The sticky toolbar is rendering on top of the modal ("Create New Page")
  • The dropdown ("Unpublish") from the top-right toolbar is also likely clipping/overlapping incorrectly.

PR - #540

Summary by CodeRabbit

  • Style
    • Improved z-index layering and stacking context for the editor interface to ensure proper visual component layering.

@gajjug004 gajjug004 changed the title revert: bubble menu hidden behind sticky toolbar #540 revert: bubble menu hidden behind sticky toolbar Feb 18, 2026
@gajjug004 gajjug004 marked this pull request as ready for review February 18, 2026 06:31
@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

The changes adjust CSS stacking contexts and z-index layering in the wiki editor components. The WikiEditor container now establishes a new CSS stacking context using isolation: isolate. Concurrently, explicit positioning and z-index rules are removed from the WikiBubbleMenu component. These modifications affect how the visual layering and stacking order of the editor and bubble menu elements are handled.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting z-index/positioning issues with the bubble menu being hidden behind the sticky toolbar, which directly addresses the problems shown in the PR description images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NagariaHussain NagariaHussain merged commit 974cbe7 into frappe:develop Feb 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants