Skip to content

fix: render tables whose inline-code cells contain a pipe#605

Merged
NagariaHussain merged 1 commit intofrappe:developfrom
NagariaHussain:fix/table-pipe-inline-code
Apr 22, 2026
Merged

fix: render tables whose inline-code cells contain a pipe#605
NagariaHussain merged 1 commit intofrappe:developfrom
NagariaHussain:fix/table-pipe-inline-code

Conversation

@NagariaHussain
Copy link
Copy Markdown
Collaborator

@NagariaHussain NagariaHussain commented Apr 22, 2026

Escape literal pipe char in tables:

telegram-cloud-photo-size-5-6287188911796719604-y

Mistune's table plugin counts raw `|` per row, so a cell like
`dict[int, dict | list]` throws the column count off and the entire
table collapses to a paragraph on the public page — even though the
editor (marked/GFM) renders it correctly. Hide the inner pipes behind
a private-use sentinel during parsing and restore them after rendering
so the `<code>` span comes out intact.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Warning

Rate limit exceeded

@NagariaHussain has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 35 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 28 minutes and 35 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 851ad443-aca3-482f-8cfc-029cc2cbc9a5

📥 Commits

Reviewing files that changed from the base of the PR and between 790a218 and 318c5a1.

📒 Files selected for processing (2)
  • wiki/wiki/markdown.py
  • wiki/wiki/test_markdown.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NagariaHussain NagariaHussain merged commit 1e3481c into frappe:develop Apr 22, 2026
5 checks passed
@NagariaHussain NagariaHussain deleted the fix/table-pipe-inline-code branch April 22, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant