fix: wiki pdf download misc fixes#625
Conversation
- Keep the actions dropdown open while the PDF is being prepared so the loading spinner stays visible; close it after the download settles. - Read the route from window.location.pathname on every click instead of caching doc.route at Alpine init — SPA navigation updates the URL via history.pushState, so this stays in sync with the visible page. - Print format: show the full breadcrumb (space › group › subgroup) in the header eyebrow, not just the space name. - Style blockquotes in the PDF to match the public-facing prose: italic, thicker left rule, and open/close quote marks on the first/last paragraph. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Frappe's print CSS pulls in Bootstrap, which sets `blockquote { padding:
10px 20px; font-size: 17.5px }` and `@media print { blockquote { border:
1px solid #999 } }`. Our `border-left` shorthand only overrode the left
side, so the top/right/bottom borders and extra padding leaked through —
the PDF showed a fully-boxed quote with vertical air around the text
instead of the public site's simple left-rule treatment.
Explicitly zero the border and padding before re-applying the left rule.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WalkthroughThis PR improves the wiki PDF download feature by making the download route dynamic and enhancing the user experience. The download URL is now derived from the current page path at click time instead of stored component state. The download action dropdown remains open while the PDF generation completes, providing better visual feedback. The print format template and styling have been updated with improved breadcrumb rendering that displays space hierarchy through ancestor traversal and refined blockquote styling for PDF output. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-ups to #624:
history.pushStatebut the cachedpageRouteon the Alpine component was stale, so clicking download on page B would download page A. Now readswindow.location.pathnameat click time.Space › Group › Subgroupinstead of just the space name.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Style
Bug Fixes