Skip to content

fix(wiki): order feedback reactions bad -> good#628

Merged
NagariaHussain merged 1 commit into
frappe:developfrom
gajjug004:fix/wiki-feedback-reaction-order
May 20, 2026
Merged

fix(wiki): order feedback reactions bad -> good#628
NagariaHussain merged 1 commit into
frappe:developfrom
gajjug004:fix/wiki-feedback-reaction-order

Conversation

@gajjug004
Copy link
Copy Markdown
Collaborator

@gajjug004 gajjug004 commented May 20, 2026

Summary

Swap reaction order in wiki feedback widget from Good/Ok/Bad to Bad/Ok/Good.

image

Summary by CodeRabbit

  • Style
    • Reordered feedback widget reaction buttons to display in a new visual sequence.

Review Change Stack

@gajjug004 gajjug004 marked this pull request as ready for review May 20, 2026 12:12
@gajjug004 gajjug004 requested a review from NagariaHussain May 20, 2026 12:12
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ee199a84-394d-461f-97e7-496f9a0d5625

📥 Commits

Reviewing files that changed from the base of the PR and between 76f63d5 and cc021d1.

📒 Files selected for processing (1)
  • wiki/templates/wiki/includes/feedback_widget.html

Walkthrough

The feedback widget template's reactions array is reordered to display the "Bad" reaction first, followed by "Ok" and "Good". Previously, the sequence was "Good", "Ok", "Bad". This change affects only the visual rendering order of the reaction pill buttons; the widget's selection logic, focus handling, and submission flow remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(wiki): order feedback reactions bad -> good' directly aligns with the PR objective to swap reaction order from Good/Ok/Bad to Bad/Ok/Good, clearly summarizing the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NagariaHussain NagariaHussain merged commit 30b4ac7 into frappe:develop May 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants