Conversation
Brings beam/web in line with the standardized lint stack across ~/code: eslint 10, @typescript-eslint, simple-import-sort, prettier. No React rules — beam/web is vanilla TS, so no @eslint-react / jsx-a11y / react-hooks needed (and no .npmrc workaround needed because there's no stale-peer plugin to install around). Brownfield adoption choices (set as 'warn' so the tool lands and CI passes; promote to 'error' as we clean up): - @typescript-eslint/no-explicit-any (~25 sites) - @typescript-eslint/no-unsafe-function-type (~2 sites) - no-console (~16 sites in error-recovery / debug paths) Real fix in this PR: - main.ts: replaced inline `as import('./connection').InputEvent` with a top-level `type InputEvent` import to satisfy consistent-type-imports. Auto-applied prettier --write across web/src (~21 files normalized). Auto-applied eslint --fix to sort imports. CI Web job adds two steps: eslint src + prettier --check src. Verified on spark-1 against the real install: tsc clean, eslint 0 errors / 47 warnings (brownfield), prettier clean, 55/55 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings beam/web in line with the standardized lint stack across ~/code (elfai, soldprice).
Stack added
eslint10 +@eslint/js10@typescript-eslint/*8.58eslint-plugin-simple-import-sort13prettier3.8No React rules — beam/web is vanilla TS, so no
@eslint-react/jsx-a11y/react-hooksneeded (and no.npmrc legacy-peer-depsworkaround needed because there's no stale-peer plugin in the chain).Brownfield adoption
Set as warnings (so tool lands + CI passes; promote to 'error' as we clean up):
@typescript-eslint/no-explicit-any(~25 sites)@typescript-eslint/no-unsafe-function-type(~2 sites)no-console(~16 sites — debug / recovery paths)Real fix in this PR
main.ts: replaced inlineas import('./connection').InputEventwith a top-leveltype InputEventimport (consistent-type-imports).Reformat
Auto-applied
prettier --writeacross web/src (~21 files normalized) andeslint --fixto sort imports.CI
Web job adds two steps:
eslint src+prettier --check src.Verification (spark-1)
npx tsc --noEmitcleannpx eslint src0 errors, 47 warnings (brownfield)npx prettier --check srccleannpx vitest run55/55 passFollow-up
Triage the 47 brownfield warnings.