Conversation
These are important for reproducible builds, but Haskell libraries are source-distributed and built on install, so they have no effect there. They also bring a minor downside when using a tool like stack-all.
- Name them `stack-ltsX`, so we don't need to maintain minor changes - Add `lts23` and `lts24` files - Maintain `stack.yaml` as a symlink to latest resolver
This CI doesn't produce or block anything useful, so it's just a waste of build minutes.
- Use `stack-action/generate` (no need for separate `nightly`) - Use newer `stack-action` with caching built-in - Use `haskell-actions`
Member
Author
|
See https://github.com/freckle/github-vending-machine/pull/161 for the corresponding branch protection requirements change. |
Contributor
|
Going to update the release step too? - if: steps.tag.outputs.tag
run: stack upload --pvp-bounds lower .
env:
HACKAGE_KEY: ${{ secrets.HACKAGE_UPLOAD_API_KEY }}
STACK_YAML: stack-lts12.yaml |
chris-martin
approved these changes
Jul 18, 2025
Member
Author
|
I always forget that! |
Member
Author
|
Oh, I don't have to. This repository uses our older |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't commit stack.yaml.lock files
These are important for reproducible builds, but Haskell libraries are
source-distributed and built on install, so they have no effect there.
They also bring a minor downside when using a tool like stack-all.
Refactor stack resolver files
stack-ltsX, so we don't need to maintain minor changeslts23andlts24filesstack.yamlas a symlink to latest resolverDon't run CI on pushes to main
This CI doesn't produce or block anything useful, so it's just a waste
of build minutes.
Modernize CI
stack-action/generate(no need for separatenightly)stack-actionwith caching built-inhaskell-actions