Conversation
This is an minor improvement over archiving as-is with documentation pushing users to `stack-action`. As a `composite`, this action should require little-to-no maintenance; only if/when `stack-action` has a major version bump. The known downsides to this approach are: 1. We lost the `cache-hit` output 2. Building with `--dry-run` does do some more work than before 3. The `setup` step installs GHC if necessary Of these, only (3) is a minor concern since it does add a bit of time. However: * It only happens on un-cached runs, and * If we assume users of this action will in fact build something somewhere, we are not _adding_ this time, only moving it Therefore, we consider this acceptable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an minor improvement over archiving as-is with documentation
pushing users to
stack-action. As acomposite, this action shouldrequire little-to-no maintenance; only if/when
stack-actionhas amajor version bump.
The known downsides to this approach are:
cache-hitoutput--dry-rundoes do some more work than beforesetupstep installs GHC if necessaryOf these, only (3) is a minor concern since it does add a bit of time.
However:
somewhere, we are not adding this time, only moving it
Therefore, we consider this acceptable.