Add "FS" command line option to the zip command #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the destination zip file already exists then it is updated in place without the "FS" option, which means it will keep any older outdated files it may already contain (e.g. a previous version.). Adding "FS" will remove any files from the existing zip that are not present in the generated artifact bundle directory.
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the destination zip file already exists then it is updated in place if you don't use the "FS" option. This means it will keep any older outdated files it may already contain (e.g. a previous version.). Adding "FS" will remove any files from the existing zip that are not present in the generated artifact bundle directory.
To reproduce the issue just use the plugin with any version number, then immediately use it again with a different version number. You'll end up with an artifact bundle that contains both versions, but an info.json file that only references the last used version number.
This isn't a problem if you are using a CI/CD system which should have a clean clone of the repo that uses this tool, but it is an issue if you bundle artifacts manually and don't clear out previously generated bundles.