Add option to use grab-and-move action for scrolling #119
Conversation
fredemmott
left a comment
fredemmott
left a comment
There was a problem hiding this comment.
Thanks, this is a great start :)
-
this needs a separate option in both the UI and the registry: there are controls in some planes that must be held, but also support scrolling - so there needs to be a way to disable this. I don't think there's a reasonable jitter value that won't have a large amount of either false positives or negatives, so I think this needs to be user preference
-
use clang-format. If you're using an IDE, its' code formatting option will probably use clang-format as thhere's a
.clang-formatfile
|
Can we reuse Config::PinchToScroll to differentiate between different gestures for scrolling, use ring and little finger pinch if true, and index finger pinch and move if false? Or we add another reg item GrabMovetoScroll and keep PinchToScroll always true? |
|
Sorry for the delay; I think this should be a separate option. PinchToScroll should be entirely independent, and only affect other fingers |
- Add new boolean config: GrabMoveToScroll (default: false) - Allows enabling/disabling grab move to scroll feature - Part of grab_move_scroll feature branch Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Adds a configurable scale factor for grab-move-to-scroll gesture. Default is 1.0, DCS configured to 4.0 via registry override.
|
I made the changes you requested, using reg instead. Please take a look |
fredemmott
left a comment
fredemmott
left a comment
There was a problem hiding this comment.
Can you also re-submit the diff with the .reg files submitted as text, not binary diffs, so the changes can be viewed and tracked correctly?
Thanks!
I resubmitted. But it seems that the original MSFS.reg and DCS.reg are UTF-16 coded. I tried to made it text but still showes as binary. You can view it directly as text though |
|
Why is a reg change needed, especially changing both per-game overrides?
|
|
I could make GrabMoveToScroll initialize to false and out of the reg file and have it set by the HTCCsetting only. But for GrabMoveToScrollScale, it is still better to set in reg file as it is different for DCS and MSFS. |
fredemmott
left a comment
fredemmott
left a comment
There was a problem hiding this comment.
FWIW, the regedit files are UTF-16 because they are/were originally raw exports from regedit, which uses UTF-16 because... classic windows.
|
This looks fine, but I want to re-review when I'm a bit less sick. Will hopefully merge tomorrow. |
|
One thing I noticed though is that when GrabMoveToScroll is set in the register file, the change in HTCCsetting makes no different. In that case, it might be better not putting GrabMoveToScroll in the reg fie, and let user to use HTCCsetting to configure it. |
|
yep, load order is:
If something's set later in the order, it takes precedence/overwrites previous values The per-game files should generally not contain any preferences - just things that are required for a game to function correctly. The line between the two is sometimes a bit blurry, and sometimes preferences to need to be overriden - for example, the MSFS reg always sets controller emulation mode, as the touch screen emulation mode is only compatible with DCS. |
|
I removed GrabMoveScroll setting from MSFS.reg. |
- it's long enough - I generally prefer early returns to nested ifs; makes it easier to follow. Extracting to a method makes this less brittle in case of future additions refs #119
2 participants
Ring to thumb pinch and little finger to thumb pinch are not reliable for many head set. This change adds option to use grab (pinch) and move gesture to imitate scrolling and knob turning. This is espeically useful for MSFS 2020 as it does not support touch screen. The feature is enabled when "Pinch to scroll" is disabled in HTCCSettings.