Bump loader-utils from 1.4.0 to 1.4.1#15
Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
Closed
Conversation
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Author
|
Superseded by #16. |
fredericd
pushed a commit
that referenced
this pull request
Apr 17, 2026
When merging (or updating) authorities, the biblios using the auths might also be updated. If this happens, Koha used to create one background job for each biblio. If an auth is used in a lot of biblios, this creates a lot of background jobs, each to index one single biblio. This patch fixes that by collecting the affected biblios and putting all of them into one reindex background job. Test plan: * Apply the patch * run the unit test t/db_dependent/Authority/Merge.t * the test should now have 16 tests in total, with a new test #15 output like this: 1..3 ok 1 - 3 bibliographic record updated while merging two authorities ok 2 - we have only one more background job ok 3 - we have the correct biblio ids in the job to be indexed ok 15 - merge with ModBiblio only creates one indexer background job for multiple biblios ok 16 - no warnings Manual test plan (rather cumbersome): * Start KTD with ElasticSearch * Create an PERSON authority (eg "100a Test") * Create three biblios which use that authority in eg 100 * Access the DB to get the count of background jobs * `ktd --dbshell` * `select count(*) from background_jobs;` * the count should be the same as the number of biblios you created (eg 3). But whatever it is, remeber it * Edit the authority (change 100 to "Test new") * check if the change is reflected in the linked biblios (100a = "Test new") * Check the Background jobs in the DB again: * `select count(*) from background_jobs;` * should be three more than previously (eg 6) * You can use this SQL to verify that the last three jobs each contain one biblionumber (which is what we want to fix): * `select json_extract(data,'$.record_ids'),enqueued_on from background_jobs order by enqueued_on desc limit 3;` +-----------------------------------+---------------------+ | json_extract(data,'$.record_ids') | enqueued_on | +-----------------------------------+---------------------+ | [2299] | 2026-03-25 13:19:34 | | [2300] | 2026-03-25 13:19:34 | | [2301] | 2026-03-25 13:19:34 | +-----------------------------------+---------------------+ * Now apply the patch and run restart_all * Edit the authority again, setting 100a to "Test new patched". * The biblios should change accordingly * Check the Background jobs in the DB again: * `select count(*) from background_jobs;` * This should now be only 1 more then the last time (so eg 7) * Check the details of the background jobs: * `select json_extract(data,'$.record_ids'),enqueued_on from background_jobs order by enqueued_on desc limit 3;` * The most recent entry should now contain three items in one row, and the following two should be the same as in the previous query (i.e. the old jobs from the edit before the patch) +-----------------------------------+---------------------+ | json_extract(data,'$.record_ids') | enqueued_on | +-----------------------------------+---------------------+ | [2299, 2300, 2301] | 2026-03-25 13:29:17 | | [2300] | 2026-03-25 13:19:34 | | [2299] | 2026-03-25 13:19:34 | +-----------------------------------+---------------------+ Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps loader-utils from 1.4.0 to 1.4.1.
Release notes
Sourced from loader-utils's releases.
Changelog
Sourced from loader-utils's changelog.
Commits
8f082b3chore(release): 1.4.14504e34fix: security problem (#220)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.