Merge orphaned PR #6#8
Merged
Merged
Conversation
pytex_protocol was a thin layer on top of pytex_markdown, and its generic frontmatter parser was already used by every Markdown variant (not just protocols). Fold the two into one module: - Promote the generic YAML frontmatter parser to pytex_markdown.frontmatter (re-exported from pytex_markdown), since it is general Markdown infrastructure, not protocol-specific. - Move the meeting-protocol rendering (convert, document, entries, header, shortcodes, signatures) under pytex_markdown.protocol, a subpackage of the base it extends. - Keep pytex_protocol as a deprecation shim that re-exports the public API from the new locations (emits DeprecationWarning). - Point internal imports (pytex_builder.variants, conftest, tests) at the canonical new paths. No behaviour change. Full suite passes; ruff + mypy --strict clean. Shim tests assert the legacy import paths still resolve to the new objects. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
basedpyright (reportImplicitStringConcatenation) fails CI on adjacent string literals; use explicit + to match the repo convention. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-into-markdown refactor: merge pytex_protocol into pytex_markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.