Skip to content

feat: adding customer reviews section #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zairahira merged 4 commits into from
May 6, 2025
Merged

feat: adding customer reviews section #750

zairahira merged 4 commits into from
May 6, 2025

Conversation

@jdwilkin4
Copy link
Contributor

@jdwilkin4 jdwilkin4 commented Apr 13, 2025 •
edited
Loading

Checklist:

Closes #711

Screenshot 2025-04-13 at 12 02 00 PM

@jdwilkin4 jdwilkin4 added the coding challenges These are for issues targeting the revamped take home projects seciton. label Apr 13, 2025
@jdwilkin4 jdwilkin4 self-assigned this Apr 13, 2025
@jdwilkin4 jdwilkin4 marked this pull request as ready for review April 13, 2025 21:33
@jdwilkin4 jdwilkin4 changed the title feat: customer reviews section feat: adding customer reviews section Apr 13, 2025
@zairahira
Copy link
Member

zairahira commented May 5, 2025

The prototype looks great.

However for the user stories, we have been using the first person in other coding challenges like this:

As a user I should be able to ...
I should see ...
I can click ...

So this one should also be updated to match the tone.

@jdwilkin4 jdwilkin4 requested a review from zairahira May 6, 2025 04:56
zairahira
zairahira approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@zairahira zairahira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@zairahira zairahira merged commit 66f768d into main May 6, 2025
1 check passed
@zairahira zairahira deleted the customer-review-section branch May 6, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zairahira zairahira zairahira approved these changes

Assignees

@jdwilkin4 jdwilkin4

Labels

coding challenges These are for issues targeting the revamped take home projects seciton. status: waiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create prototype for Customers review section

3 participants

@jdwilkin4 @zairahira