Skip to content

Conversation

@a2937
Copy link
Member

@a2937 a2937 commented Aug 2, 2025

Checklist:

Related to Typescript Tarot Card

I'm absolutely certain these cards are too big. That being said I need a good width and height for these images.

We have to be prepared to go without, but images are nice.

Edit: I'm updating the PR to remove some cards so that campers will have to use optional types in the workshop. Additionally this PR will contain the data needed to make the workshop work.

@a2937 a2937 marked this pull request as ready for review August 3, 2025 01:25
@a2937 a2937 requested a review from a team August 3, 2025 01:25
@majestic-owl448
Copy link
Contributor

where did you found these? do the images have copyright?

@a2937
Copy link
Member Author

a2937 commented Aug 3, 2025

I downloaded them from here. https://archive.org/details/rider-waite-tarot

And they are indeed in public domain. https://en.m.wikipedia.org/wiki/Rider-Waite_tarot_deck

Copy link
Contributor

@majestic-owl448 majestic-owl448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for confirming they are public domain

@majestic-owl448 majestic-owl448 merged commit 0a9086b into freeCodeCamp:main Aug 4, 2025
2 checks passed
@a2937 a2937 deleted the feat/add-tarot-cards branch August 4, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants