Skip to content

fix(a11y): make play/pause button more accessible #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2020
Merged

fix(a11y): make play/pause button more accessible #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/components/PlayPauseButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ class PlayPauseButton extends React.Component {

handleOnTouchStart = () => !isBrowser && this.props.togglePlay();

handleKeyDown = e => {
// Toggle play when user presses Enter
// The Space keypress event is ignored to avoid collision with the GlobalHotKeys
if (e.keyCode === 13) {
this.handleOnClick();
}
};

static getDerivedStateFromProps(nextProps, prevState) {
// set initial load to render the initial message accordingly
if (prevState.initialLoad && nextProps.playing) {
Expand All @@ -25,10 +33,14 @@ class PlayPauseButton extends React.Component {
render() {
return (
<div
aria-label={this.props.playing ? "Pause" : "Play"}
className={this.state.initialLoad ? "cta" : ""}
id="playContainer"
onClick={this.handleOnClick}
onKeyDown={this.handleKeyDown}
onTouchStart={this.handleOnTouchStart}
role="button"
tabIndex={0}
>
{this.props.playing ? <Pause /> : <Play />}
</div>
Expand Down