Skip to content

Add OpenJDK version 15#1458

Merged
simon04 merged 3 commits intofreeCodeCamp:masterfrom
MasterEnoc:openjdk
Feb 2, 2021
Merged

Add OpenJDK version 15#1458
simon04 merged 3 commits intofreeCodeCamp:masterfrom
MasterEnoc:openjdk

Conversation

@MasterEnoc
Copy link
Copy Markdown
Contributor

@MasterEnoc MasterEnoc commented Jan 4, 2021

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

This is a WIP PR, Openjdk 16 still has some style issues.

All the tables are made with 'div' tags rather than table (th, tr, td, etc) tags, this has been painfully hard to work with and I have not found a good way to fix this.
image

All the other version work as expected and have good styles.

@MasterEnoc MasterEnoc requested a review from a team as a code owner January 4, 2021 19:54
@simon04
Copy link
Copy Markdown
Contributor

simon04 commented Jan 7, 2021

The resulting OpenJDK 16 documentation is very hard to read (for Color):
Screenshot 2021-01-07 at 20 57 12
Screenshot 2021-01-07 at 20 57 28
Screenshot 2021-01-07 at 20 57 46

Should we omit version 16 for now and only add versions 13/14/15?


Version 15 could get some syntax highlighting as indicated in this screenshot:
Screenshot 2021-01-07 at 21 09 11

@MasterEnoc
Copy link
Copy Markdown
Contributor Author

MasterEnoc commented Jan 30, 2021

Version 16 removed and syntax highlight improved for version 15.

Notice that syntax highlight in the summary tables can lead to undesirable format (at least using prismjs):
image
For this reasons syntax highlight was not applied to summary tables.

@MasterEnoc MasterEnoc changed the title Add Openjdk version 13, 14, 15 and 16 Add Openjdk version 13, 14, 15 Jan 30, 2021
End of life. No longer provided on packages.debian.org
@simon04 simon04 changed the title Add Openjdk version 13, 14, 15 Add OpenJDK version 15 Feb 2, 2021
@simon04 simon04 self-assigned this Feb 2, 2021
@simon04
Copy link
Copy Markdown
Contributor

simon04 commented Feb 2, 2021

I've removed versions 13 and 14 since they're end of life and no longer provided on packages.debian.org

Copy link
Copy Markdown
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simon04 simon04 merged commit d687118 into freeCodeCamp:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants